Skip to content

GPU: Some cleanup for QA, DataTypes, sync mode settings #14914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidrohr merged 3 commits into from
Dec 14, 2025
Merged

GPU: Some cleanup for QA, DataTypes, sync mode settings #14914

davidrohr merged 3 commits into from
Dec 14, 2025
+494 −420

Conversation

@davidrohr
Copy link
Collaborator

@davidrohr davidrohr commented Dec 11, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented Dec 12, 2025

Error while checking build/O2/fullCI_slc9 for 52f2925 at 2025-12-12 02:50:

## sw/BUILD/O2-latest/log
input_line_9:180:97: error: no type named 'RecoStepField' in namespace 'o2::gpu::gpudatatypes'
Error: /sw/slc9_x86-64/ROOT/v6-36-04-alice3-local1/bin/rootcling: compilation failure (/sw/BUILD/be7c0b7de27ee9fdd0e87521438732d85db04599/O2/GPU/GPUTracking/Interface/G__O2GPUO2Interfacea1ccf89a5c_dictUmbrella.h)
/sw/SOURCES/O2/14914-slc9_x86-64/0/GPU/GPUTracking/display/GPUDisplay.h:208:59: error: 'GPUTPCGMPropagator' does not name a type
/sw/SOURCES/O2/14914-slc9_x86-64/0/GPU/GPUTracking/display/GPUDisplay.h:208:59: error: 'GPUTPCGMPropagator' does not name a type; did you mean 'GPUTPCGMPROPAGATOR_H'?
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Dec 12, 2025

Error while checking build/O2/fullCI_slc9 for f188456 at 2025-12-12 18:52:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14914-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/include/TRKWorkflow/RecoWorkflow.h:28:41: error: 'o2::gpu::gpudatatypes::DeviceType' has not been declared
/sw/SOURCES/O2/14914-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/include/TRKWorkflow/RecoWorkflow.h:28:106: error: 'o2::gpu::gpudatatypes::DeviceType' has not been declared
/sw/SOURCES/O2/14914-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/src/trk-reco-workflow.cxx:70:55: error: 'DeviceType' in namespace 'o2::gpu::gpudatatypes' does not name a type
/sw/SOURCES/O2/14914-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/include/TRKWorkflow/RecoWorkflow.h:28:41: error: 'o2::gpu::gpudatatypes::DeviceType' has not been declared
/sw/SOURCES/O2/14914-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/workflow/include/TRKWorkflow/RecoWorkflow.h:28:106: error: 'o2::gpu::gpudatatypes::DeviceType' has not been declared
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Dec 13, 2025

Error while checking build/O2/fullCI_slc9 for 8bc5545 at 2025-12-13 17:13:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14914-slc9_x86-64/0/Detectors/Upgrades/ALICE3/ECal/DataFormatsECal/src/Cluster.cxx:53:14: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@davidrohr davidrohr merged commit 670518f into AliceO2Group:dev Dec 14, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@arossi81 arossi81 Awaiting requested review from arossi81 arossi81 is a code owner

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

@f3sch f3sch Awaiting requested review from f3sch f3sch is a code owner

@njacazio njacazio Awaiting requested review from njacazio njacazio is a code owner

@bazinski bazinski Awaiting requested review from bazinski bazinski is a code owner

@wille10 wille10 Awaiting requested review from wille10 wille10 is a code owner

@wiechula wiechula Awaiting requested review from wiechula wiechula is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

@fprino fprino Awaiting requested review from fprino fprino is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidrohr @alibuild